perf: Deserializing json without a try-catch block to increase speed

Cammin · May 20, 2024 · b0cec83 · b0cec83
1 parent 9a380fb
commit b0cec83
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/Assets/LDtkUnity/Editor/ScriptedImporter/LDtkJsonImporter.cs b/Assets/LDtkUnity/Editor/ScriptedImporter/LDtkJsonImporter.cs
@@ -319,11 +319,19 @@ internal abstract class LDtkJsonImporter<T> : LDtkJsonImporter where T : Scripta
     {
         protected T ReadAssetText()
         {
+            LDtkProfiler.BeginSample("ReadAllText");
             string jsonText = File.ReadAllText(assetPath);
+            LDtkProfiler.EndSample();
 
+            LDtkProfiler.BeginSample("ScriptableObject.CreateInstance");
             T file = ScriptableObject.CreateInstance<T>();
+            LDtkProfiler.EndSample();
+
+            LDtkProfiler.BeginSample( "SetJson");
             file.name = Path.GetFileNameWithoutExtension(assetPath) + "_Json";
             file.SetJson(jsonText);
+            LDtkProfiler.EndSample();
+
             return file;
         }
 
@@ -346,16 +354,8 @@ public static TJson FromJson<TJson>(string path, LDtkDebugInstance debug = null)
             byte[] bytes = File.ReadAllBytes(path);
             LDtkProfiler.EndSample();
 
-            LDtkProfiler.BeginSample($"FromJson");
-            TJson json = default;
-            try
-            {
-                json = Utf8Json.JsonSerializer.Deserialize<TJson>(bytes);
-            }
-            catch (Exception e)
-            {
-                LDtkDebug.LogError($"Failure to deserialize json: {e}", debug);
-            }
+            LDtkProfiler.BeginSample($"Deserialize");
+            TJson json = Utf8Json.JsonSerializer.Deserialize<TJson>(bytes);
             LDtkProfiler.EndSample();
 
             LDtkProfiler.EndSample(); //this end sample for the caller up the stack