Refactor main admin: phase 1 #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 16, 2019 13:50
|
Using the gutenberg panels component on the right side. Rest of the page is still jQuery-powered for now. On page load -I am canablizing the Vue components we had for pro. The pro ui here should replace the pro settings page. With translate tab open:Most content is coming in via REST API. Probably all of it should be.
Add-on searchBased on the extend tab's HTML/CSS and shares endpoints with the old add-on search on website.
Documentation search@New0 Make sure I fix the checkbox css
|
Shelob9
pushed a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #3204 #2445
This PR replaces #3213
This PR is step one in refactoring the main admin page, so it is a React-driven application. It merges the doc search package https://github.com/CalderaWP/caldera-forms-docs-search
Goals:
Increase upsells by making add-ons/ pro more obvious #3204
Make it easier to add the new entry viewer and sortable form list #1912'
Make documentation easier to find.
Move API key management for Pro and add-ons to main page. #3212
Problem:
I used React 16.8, we need to target 16.6.3 see #3205 . Rolling back to 8105aaa fixes this. Undoes a lot of my work though.
I'm trying to do code-splitting, I had to do a hack in my local to make it load the chunks properly. Need to think about that.
ba22a4d#diff-2fe7b4b157fe073101fb2aa46627aa9eR7