Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make which admin script loads determined by filter #2789

Closed
Shelob9 opened this issue Oct 24, 2018 · 2 comments
Closed

Make which admin script loads determined by filter #2789

Shelob9 opened this issue Oct 24, 2018 · 2 comments
Assignees
@Shelob9
Labels
enhancement New feature
Milestone
1.8.0

Comments

@Shelob9
Copy link
Collaborator

Shelob9 commented Oct 24, 2018

Default of filter will be new if on main page and false if on any other page.
@Shelob9 Shelob9 added the enhancement New feature label Oct 24, 2018
@Shelob9 Shelob9 added this to the 1.8.0 milestone Oct 24, 2018
@Shelob9 Shelob9 self-assigned this Oct 24, 2018
@Shelob9 Shelob9 mentioned this issue Oct 24, 2018
Open
Shelob9 referenced this issue Oct 24, 2018
@New0
Generate css file in build folder using Webpack
b615414 
@Shelob9 This generates the build version of index.scss, the clients/admin/build/style.min.css still needs to be enqueued and I'm not sure if we want to enqueue css files from the clients folder or move theme and enqueue from the assets folder.
BTW, the admin client is loading these styles via import within the index.js file, once we decide where we enqueue css from we can remove the import.
Shelob9 pushed a commit that referenced this issue Oct 24, 2018
new filter to set if admin client is used for admin.js or not #2789
f1adb08
Shelob9 pushed a commit that referenced this issue Oct 24, 2018
enqueue the CSS for new admin client #2789 #2445
9bf3657
@Shelob9
Copy link
Collaborator Author

Shelob9 commented Oct 24, 2018

Resolved via 9bf3657 and f1adb08

Now in the admin page, we get new CSS and JS from admin client and in editor we get older version.

@New0 What is left for you to decide is how much of the legacy CSS assets/css/admin.css we want to use. I think that copying that file to a legacy.scss that gets included for now is a good start, then go through and delete non-required CSS (a lot of that shit is for the editor) not worrying about how it effects the editor or other screens that use that CSS (privacy, some add-on admins)

@Shelob9
Copy link
Collaborator Author

Shelob9 commented Nov 20, 2018

clsoe via 9bf3657 and f1adb08

@Shelob9 Shelob9 closed this as completed Nov 20, 2018
Shelob9 pushed a commit that referenced this issue May 17, 2019
bring in remote post componet from #2445 and #2789 for #3204
12054cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shelob9 Shelob9

Labels
enhancement New feature
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
1 participant
@Shelob9