Fix delay with FREX Flawless Frames #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMS212
reviewed
Jul 16, 2024
src/main/java/net/caffeinemc/mods/sodium/client/render/SodiumWorldRenderer.java
Outdated
Show resolved
Hide resolved
IMS212
pushed a commit
that referenced
this pull request
Aug 1, 2024
* Fix delay with FREX Flawless Frames due to dependency between building & visibility * Add iteration limit based on renderDistance
IMS212
pushed a commit
that referenced
this pull request
Aug 1, 2024
* Fix delay with FREX Flawless Frames due to dependency between building & visibility * Add iteration limit based on renderDistance
IMS212
pushed a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
* Fix delay with FREX Flawless Frames due to dependency between building & visibility * Add iteration limit based on renderDistance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix delay with FREX Flawless Frames due to dependency between building & visibility.
In order for a chunk to be built, it must be visible.
In order for a chunk to become visible via the graph search, it must have a neighbor that is built.
This dependency results in the graph search propagating visibility one section at a time. Normally this would be unnoticeable, but when using FREX Flawless Frames we want the entire world to be visible ASAP.
The solution in this PR is to simply to do building & visibility in a loop until there are no chunks left to build (but only when flawless frames is on)
This has also been ported to 1.20.6 here, might be useful as a reference if doing another 1.20.6 release: https://github.com/Moulberry/sodium-fabric/tree/fix_flawless_frames_delay/1.20.6