-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked leaves textures as well as adding waterlogging support. #2512
base: dev
Are you sure you want to change the base?
Conversation
I'm not okay with breaking resource pack compatibility for adding waterlogged textures into the game. For the most part, we don't even encourage using Fast Graphics mode since it offers little to no performance improvement and introduces all kinds of issues with texture handling. |
That said, can you please elaborate on how you "improved" the existing textures? I don't see much of a difference from the screenshots given. There are bugs like #2422 but I don't actually understand what is described or if your pull request fixes this. |
My textures are not inherently better just done in a consistent method, They were more so made in a methodology that avoided copying any part of vanilla tweaks to avoid any potential concerns of copying(cleanroom per say), however the programmer art leaves should be the most updated ones possible, they uses the latest assets from programmer art in 1.20.6. I can update this pr with the removal of water logging blockstates/textures if you still would like the other aspects. |
If you can create a new pull request with just the changes that update the Leaves textures, that would be appreciated. Let's not change the purpose of this pull request in case it's useful in the future. |
That includes both regular and programmer art textures correct? |
Yes, both sets of textures. |
Remade the better leaf system from scratch, and alongside that, I included an experimental waterlogging system that helps people visually see waterlogged leaves with fast graphics.
What's currently included:
Known and/or potential issues:
Something to note: For packs to add support for waterlogged leaves, they will need to add a folder called "
waterlogged
" in "textures/block/
". In that folder, they can add their own form of waterlogged leaves or simply copy their existing texture there if they don't care to support waterlogged leaves on fast graphics.When it comes to models, most models should simply work, as they are only replacing the texture. There is a niche case where it could still break, but it is extremely unlikely.
If requested, I may remove waterlogged support due to the issues that it can cause.