-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations to vanilla block models #2508
base: dev
Are you sure you want to change the base?
Conversation
Wouldn't doing ones that fix custom texture mapping break some custom resource packs which are adapted to the fact that they have broken texture mapping? If that is the case, shouldn't we just optimise it and remember to keep them looking the same as vanilla? (the looking same as vanilla should also be for everything in this PR) |
And if we are using the attached resource packs in the Mojiras to optimise the models, shouldn't we have a credits thanking them for their work? |
Please just make them look vanilla (I don't mind them looking different if clip in in spectator mode), as people might want them to actually look vanilla and not just ignore the fact it doesn't look vanilla. You have said that fixes for #1316 and #1902 may make this not visible, so please test on top of those commits. If it is harder to see, still best to keep vanilla in my opinion. |
As far as I know, this is Muzikbike's original work. If it's not, then we need to know, since we require that all contributions be the submitter's original work... |
The changes seem fine to me. The minor details you mentioned are very unlikely to cause issues. But, for us to import these into the repository, each model file should probably have documentation (in the form of a |
@muzikbike Do you have any update on this? I'd like to merge it if you think it's ready. The only remaining blocks that don't appear to be addressed by this pull request are not so common in the world anyways (Dragon Eggs, Flower Pots, Cauldrons...), so the performance impact of improving them is very, very small. |
Apparently dragon eggs got optimized (MC-262652 was fixed) in the latest snapshot |
I'd prefer to finish optimizing the remaining blocks. Cauldrons are a major offender and show up in a good handful of farms, so those are a priority to fix. |
Fixes #2460.
Models optimized so far:
Models I'm still to do:
See #2460 for explanations of these optimizations as well as performance comparisons.