Add API to allow conditional rendering of block entities #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend BlockEntityType to store a predicate, always returning true by default. - Evaluate the predicate in ChunkBuilderMeshingTask before fetching the BlockEntityRenderer. - Expose a method to set the predicate for a given BlockEntityType in the API.
# Conflicts: # src/main/java/me/jellysquid/mods/sodium/client/render/chunk/compile/tasks/ChunkBuilderMeshingTask.java # src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/BlockEntityRenderHandlerImpl.java # src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/ExtendedBlockEntityType.java # src/main/java/net/caffeinemc/mods/sodium/mixin/core/render/BlockEntityTypeMixin.java # src/main/resources/sodium.mixins.json
# Conflicts: # common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/BlockEntityRenderHandlerImpl.java # common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/ExtendedBlockEntityType.java # common/src/main/java/net/caffeinemc/mods/sodium/mixin/core/render/BlockEntityTypeMixin.java # common/src/main/resources/sodium.mixins.json
jellysquid3
approved these changes
Aug 28, 2024
IThundxr
pushed a commit
to IThundxr/sodium-fabric
that referenced
this pull request
Sep 2, 2024
…2316) * Add API to allow conditional rendering of block entities - Extend BlockEntityType to store a predicate, always returning true by default. - Evaluate the predicate in ChunkBuilderMeshingTask before fetching the BlockEntityRenderer. - Expose a method to set the predicate for a given BlockEntityType in the API. * Update to latest dev * Fix build * Merge files * Make the predicate an array * Use custom predicate class --------- Co-authored-by: IMS212 <ims@irisshaders.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a way for other mods to fully take over rendering of specific block entities.
The solution here is to expose an API by which users associate a predicate with a block entity type.
If that predicate returns
falsefor a given block entity, that block entity will not be added to a chunk'sBuiltSectionInfo, and will therefore never be considered for rendering later on.The predicate is stored directly in the given block entity type via a mixin'd interface.