-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resolution control option to the config screen #2296
base: dev
Are you sure you want to change the base?
Conversation
The resolution controls would not fit in the allocated space, so I changed the rendering of slidercontrols to enable rendering the slider bar and the value text in the same area. Signed-off-by: MeeniMc <68366846+MeeniMc@users.noreply.github.com>
reduce the length of scrollbars so that it doesn't look as busy Signed-off-by: MeeniMc <68366846+MeeniMc@users.noreply.github.com>
Note that I did not implement FOV, Distortion, Glint Speed, Glint Strenght, because these are duplicated in the vanilla video options from the accessibility option menu and so are still available without 'tricks'. Under these assumption that we don't want to re-replicate them, we now have all options covered. |
…hat the box can be reduced to avoid overlapping with the undo button. Signed-off-by: MeeniMc <68366846+MeeniMc@users.noreply.github.com>
ready for review. |
c36e5d0
to
aa14bb8
Compare
updated for mojmap As for the discussion regarding delaying this after a full config screen refactor, here are some arguments in favor of acting now
|
Adds resolution control (missing option as compared to Vanilla Shift-P options).
fixes #46
The resolution controls would not fit in the allocated space, so I changed the rendering of slidercontrols to enable rendering the slider bar and the value text in the same area.
The code is mostly new but is liberally inspired from #957 (in particular the setBinding part)
This is how it looks like:
![2024-01-31_10 25 23](https://private-user-images.githubusercontent.com/68366846/301215812-ee268ccb-c922-49bb-861e-f4f52bc6d4fd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1Njg0ODEsIm5iZiI6MTcyNTU2ODE4MSwicGF0aCI6Ii82ODM2Njg0Ni8zMDEyMTU4MTItZWUyNjhjY2ItYzkyMi00OWJiLTg2MWUtZjRmNTJiYzZkNGZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA1VDIwMjk0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYxNDk1NTU4YmNiYzBlMGYyY2YzOGMxMDNhNjExOWRjMjg1OThmOTY4NDQ1MzVhMjNmMGVjZjE2MmFiZDkxNTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.21RQMYB80iTW2rRQWUKtqjMGek869Ccd3R7XhAnK9WA)