-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardened Gradle builds with Gradle dependency verification and defined module restrictions on third-party maven repositories. #2174
base: dev
Are you sure you want to change the base?
Conversation
…d module restrictions on third-party maven repositories. This prevents anyone from replacing dependencies from under our feet for any purpose, either with malicious intent or by accident. See the Gradle documentation for more information: https://docs.gradle.org/current/userguide/dependency_verification.html
modImplementation "net.fabricmc:fabric-loader:${project.loader_version}" | ||
repositories { | ||
// Log if any unknown repositories were added non-explicitly. | ||
forEach { repo -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed if you don't like it.
minecraft "com.mojang:minecraft:${project.minecraft_version}" | ||
mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2" | ||
modImplementation "net.fabricmc:fabric-loader:${project.loader_version}" | ||
repositories { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire repositories
block is not strictly required either but prevents downloading artifacts from the wrong place.
I have left some comments on the |
Thanks for this pull request. We talked about it again earlier today, and I think it's a great improvement to the build pipeline. This will help prevent some kinds of build pipeline attacks, and certainly catch many subtle issues on the CI/CD. I want to investigate merging this for the next major release, as changing it now in the Sodium 0.5.x branch would probably be disruptive to other projects and developers. |
I also think we will likely need some documentation added to the repository (possibly CONTRIBUTING.md) explaining how this works, and how to update the pinned dependencies. As far as I can tell, we'd be one of the only Fabric mods doing this, so people aren't going to be familiar with it. |
This prevents anyone from replacing dependencies from under our feet for any purpose, either with malicious intent or by accident.
See the Gradle documentation for more information:
https://docs.gradle.org/current/userguide/dependency_verification.html