Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waterlogged double slabs and stairs have Z-fighting when rendered next to water #2606

Closed
Lolothepro opened this issue Jul 16, 2024 · 6 comments · Fixed by #2649
Closed

Waterlogged double slabs and stairs have Z-fighting when rendered next to water #2606

Lolothepro opened this issue Jul 16, 2024 · 6 comments · Fixed by #2649
Labels
F-good-first-issue Flag: Good first issue for new contributors T-bug Type: Bug
Milestone
Sodium 0.6

Comments

@Lolothepro
Copy link
Contributor

Lolothepro commented Jul 16, 2024 •
edited
Loading

Bug Description

3d4cf6a

I suspect that this commit causes undesirable side effects with waterlogged double slabs.

Sodium:

image

Vanilla:

image
‎
‎
‎
It causes Z-Fighting with Sodium
i.e:
2024-07-16_23 56 33
2024-07-16_23 56 31

Reproduction Steps

Make a wall of waterlogged double slabs
Switch to spectator mode
Go into the wall or move away from the wall

Log File

https://mclo.gs/wS0lUP4

Crash Report
@Lolothepro Lolothepro added the S-needs-triage Status: Needs triage label Jul 16, 2024
@douira

This comment was marked as resolved.

Sign in to view
@Lolothepro

This comment was marked as resolved.

Sign in to view
@douira

This comment was marked as resolved.

Sign in to view
@Lolothepro

This comment was marked as resolved.

Sign in to view
@douira

This comment was marked as resolved.

Sign in to view
@Lolothepro Lolothepro changed the title The fluid occlusion code causes an undesirable effect with waterlogged double slabs (Z-Fighting) (Sodium 0.5.11 only) The fluid occlusion code causes an undesirable effect with waterlogged double slabs (Z-Fighting) (Sodium 0.5.11+ only) Jul 26, 2024
@MeeniMc
Copy link
Contributor

MeeniMc commented Jul 27, 2024

presumed root cause is bc38d56 : that code changed the test on isFaceSturdy on the pos, dir to the adjPos, dir.getOpposite(). It makes sense for the case when the water is occluded by a neighbor block, but that removed the test for water being occluded by the faces of the waterlogged block itself.

This also causes z-fighting on full-faces of waterlogged stairs.

@jellysquid3 jellysquid3 added T-bug Type: Bug F-good-first-issue Flag: Good first issue for new contributors and removed S-needs-triage Status: Needs triage labels Aug 7, 2024
@jellysquid3 jellysquid3 changed the title The fluid occlusion code causes an undesirable effect with waterlogged double slabs (Z-Fighting) (Sodium 0.5.11+ only) Waterlogged double slabs and stairs have Z-fighting when rendered next to water Aug 7, 2024
MCRcortex added a commit to MCRcortex/sodium-fabric that referenced this issue Aug 9, 2024
@MCRcortex
Fix for CaffeineMC#2606
7b43e2f
@MCRcortex MCRcortex mentioned this issue Aug 9, 2024
Merged
@Lolothepro Lolothepro mentioned this issue Aug 11, 2024
Closed
@jellysquid3 jellysquid3 added this to the Sodium 0.6 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F-good-first-issue Flag: Good first issue for new contributors T-bug Type: Bug
Projects
None yet
Milestone
Sodium 0.6
Development

Successfully merging a pull request may close this issue.

Fix for #2606 MCRcortex/sodium-fabric
4 participants
@jellysquid3 @douira @Lolothepro @MeeniMc