Hide disabled issue in get_allowed_devices #5654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is actually a Cacti bug, you are seeing it for sure, but it's not the right fix. It's a bit more involved. |
|
fixed #5655 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function read_user_setting($config_name, $default = false, $force = false, $user = 0)
This function contains condition for user_id:
if ($user == 0 && isset($_SESSION['sess_user_id'])) {
Current code causes issue in intropage (maybe more). Few things are called from poller without SESSION['sess_user_id']
So get_allowed_issues never returns disabled devices in list.