Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When user session not found, device lists can be incorrectly returned #5655

Closed
xmacan opened this issue Jan 28, 2024 · 2 comments
Closed

When user session not found, device lists can be incorrectly returned #5655

xmacan opened this issue Jan 28, 2024 · 2 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
1.2.27

Comments

@xmacan
Copy link
Member

xmacan commented Jan 28, 2024

Problem is if user_id session variable is not set, user_id 0 is used. So function returns unexpected list. It causes problem in intropage.
@xmacan xmacan added bug Undesired behaviour unverified Some days we don't have a clue labels Jan 28, 2024
@xmacan xmacan mentioned this issue Jan 28, 2024
Closed
@TheWitness
Copy link
Member

Yea, I get it. There is more than one location though and a few components out of order.

@TheWitness TheWitness changed the title Get_allowed_devices can returns incorrect device list if session user_id variable is not set Function get_allowed_devices can returns incorrect device list if session user_id variable is not set Jan 29, 2024
@TheWitness TheWitness added confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Jan 29, 2024
@TheWitness TheWitness added this to the 1.2.27 milestone Jan 29, 2024
TheWitness added a commit that referenced this issue Jan 29, 2024
@TheWitness
Fixing #5655 - Hide Devices Settings
0f2cd43 
Function get_allowed_devices can returns incorrect device list if session user_id variable is not set
@TheWitness
Copy link
Member

Please review the commit.

@TheWitness TheWitness added the resolved A fixed issue label Jan 29, 2024
TheWitness added a commit that referenced this issue Jan 29, 2024
@TheWitness
Fixing #5655 - Hide Devices Settings
fbd1b4b 
Function get_allowed_devices can returns incorrect device list if session user_id variable is not set
@netniV netniV changed the title Function get_allowed_devices can returns incorrect device list if session user_id variable is not set When user session not found, device lists can be incorrectly empty Apr 28, 2024
@netniV netniV changed the title When user session not found, device lists can be incorrectly empty When user session not found, device lists can be incorrectly returned Apr 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
1.2.27
Development

No branches or pull requests
2 participants
@TheWitness @xmacan