-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming according to convention #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
- "Constants"
- "Pieces"
- "View"
- "Entities"
also have to be all lower case to adhere with java conventions proper naming of packages/folders
I agree with AscendedWise for the package/folders naming. For the program and tests not running, try
in IntelliJ. |
Remaining package name changes
Use case tests
Revert "Use case tests"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I like that you went back to change the naming conventions in tests as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if the all the documentations are still there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything weird anymore. I approve.
All package, class, method and variable names have been refactored. I have ran the game, and tried the following to see if they work
Naming conventions used (in accordance with Java conventions)
The tests currently don't run because they can't import the packages for some reason. I'm having trouble fixing this, if anyone has some time, please take a look.
Please pull and run the branch before merging to ensure none of the original functionality has been compromised.