Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming files #73

Closed
nawarani opened this issue Aug 11, 2023 · 1 comment · Fixed by #84
Closed

Renaming files #73

nawarani opened this issue Aug 11, 2023 · 1 comment · Fixed by #84
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@nawarani
Copy link
Contributor

All package, class, method and variable names have been refactored. I have ran the game, and tried the following to see if they work

  • all piece movement
  • capture
  • en passant
  • check
  • castling
  • leaderboard
  • forfeit
  • draw

Naming conventions used (in accordance with Java conventions)

  • package names are all lowercase, multiple words becomes concatenated. i.e Frameworks_and_Drivers -> frameworksanddrivers
  • Class names start with uppercase and continue in camelCase. i.e. LocationBitboard
  • method and variable names start lowercase and continue in camelCase. i.e. whitePawnAttacks() and whitePawnAttacks
  • constants are all uppercase separated by underscores. I have verified the use of underscore for constants with the java conventions. i.e. WHITE_PAWN

The tests currently don't run because they can't import the packages for some reason. I'm having trouble fixing this, if anyone has some time, please take a look.
Please pull and run the branch before merging to ensure none of the original functionality has been compromised.

@nawarani nawarani self-assigned this Aug 11, 2023
@nawarani nawarani added this to the Milestone #4 milestone Aug 12, 2023
@nawarani nawarani linked a pull request Aug 12, 2023 that will close this issue
@AscendedWise AscendedWise added the documentation Improvements or additions to documentation label Aug 13, 2023
@123Chan 123Chan linked a pull request Aug 14, 2023 that will close this issue
@123Chan
Copy link
Contributor

123Chan commented Aug 14, 2023

Successfully Completed, great job!

@123Chan 123Chan closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
3 participants