Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate_children_dag() doesn't check for acyclicity #455

Closed
cqc-alec opened this issue Aug 24, 2023 · 0 comments · Fixed by #468
Closed

validate_children_dag() doesn't check for acyclicity #455

cqc-alec opened this issue Aug 24, 2023 · 0 comments · Fixed by #468
Assignees
@cqc-alec
Labels
bug Something isn't working

Comments

@cqc-alec
Copy link
Collaborator

It uses DfsPostOrder from petgraph; it should probably use Topo.
@cqc-alec cqc-alec added the bug Something isn't working label Aug 24, 2023
@cqc-alec cqc-alec self-assigned this Aug 30, 2023
@cqc-alec cqc-alec mentioned this issue Aug 30, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 30, 2023
@cqc-alec
Check for acyclicity; remove boundedness requirement (#468)
c7bfffe 
Fixes #455 .
Fixes #447 .
Fixes #435 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqc-alec cqc-alec

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for acyclicity; remove boundedness requirement CQCL/hugr
1 participant
@cqc-alec