Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPC-4220] Add max failed attempts to invite verification #2261

Merged
merged 84 commits into from
Sep 13, 2024
Merged

[DPC-4220] Add max failed attempts to invite verification #2261

merged 84 commits into from
Sep 13, 2024

Conversation

ashley-weaver
Copy link
Contributor

@ashley-weaver ashley-weaver commented Sep 4, 2024 •
edited
Loading

🎫 Ticket

https://jira.cms.gov/browse/DPC-4220

🛠 Changes

ℹ️ Context

🧪 Validation

Invalid code error
image

Max tries exceeded error
image

ashley-weaver and others added 30 commits September 4, 2024 14:46
@ashley-weaver
Add max tries validation
193cf70
@ashley-weaver
Set tries_count
5376a7e
@ashley-weaver
Merge branch 'main' into aweaver/add-invite-limit
c7798c1
@ashley-weaver
Add requests test
c71b092
@ashley-weaver
Remove method
d2b1367
@ashley-weaver
Update invitations_spec.rb
ab6fc22
@ashley-weaver
Linter
817c29b
@ashley-weaver
Fix test
336fae4
@ashley-weaver
Update invitation.rb
806c175
@ashley-weaver
Put method back
588b2b8
@ashley-weaver
Use failed attempts
5ad3611
@ashley-weaver
Add migration
a077da0
@ashley-weaver
Update invitations_spec.rb
8d02d7b
@ashley-weaver
Remove accessor
7f1b5b5
@ashley-weaver
Save failed attempts count
7058332
@ashley-weaver
Update invitations_controller.rb
a6fc58d
@ashley-weaver
Move return for double render error
57af60a
@ashley-weaver
Use redirect
c5a91f5
@ashley-weaver
Use if-else
0a75712
@ashley-weaver
Use another if-else
baae1a2
@ashley-weaver
Remove doubled method
0c96db7
@ashley-weaver
Move save to invite model
4ffb9ee
@ashley-weaver
Fix spec and update attr
c337683
@ashley-weaver
Debug
ccedf44
@ashley-weaver
Update invitations_spec.rb
4cdefad
@ashley-weaver
Debug
d4cb2fc
@ashley-weaver
Update invitations_controller.rb
0d76db1
@ashley-weaver
Refactor attempts_remaining
3b86fd4
@ashley-weaver
Update invitations_controller.rb
4bf560f
@ashley-weaver
Refactor add_failed_attempt
a755abf
@ashley-weaver ashley-weaver changed the title [DPC-4220] Add max tries validation [DPC-4220] Add max failed attempts to invite verification Sep 10, 2024
jdettmannnava
jdettmannnava reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@jdettmannnava jdettmannnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to add max_tries_exceeded to Invitation#uncacceptable_reason

dpc-portal/app/controllers/invitations_controller.rb Outdated Show resolved Hide resolved
dpc-portal/app/controllers/invitations_controller.rb Outdated Show resolved Hide resolved
dpc-portal/app/models/invitation.rb Outdated Show resolved Hide resolved
dpc-portal/app/models/invitation.rb Outdated Show resolved Hide resolved
dpc-portal/app/models/invitation.rb Outdated Show resolved Hide resolved
jdettmannnava
jdettmannnava approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@jdettmannnava jdettmannnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashley-weaver ashley-weaver merged commit 45b558e into main Sep 13, 2024
5 checks passed
@ashley-weaver ashley-weaver deleted the aweaver/add-invite-limit branch September 13, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdettmannnava jdettmannnava jdettmannnava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashley-weaver @jdettmannnava