Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving model to top level #388

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Moving model to top level #388

merged 9 commits into from
Aug 20, 2024

Conversation

gvegayon
Copy link
Member

@gvegayon gvegayon commented Aug 16, 2024 •
edited
Loading

  • Merges ./README.md with model/README.md.
  • Moves all the content under model to ..
  • Adjust the paths for GHA to ensure they run under the new project structure.

@gvegayon gvegayon linked an issue Aug 16, 2024 that may be closed by this pull request
Separate pipeline from pyrenew #208
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (a5f8905) to head (b92a43b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files          39       39           
  Lines         941      941           
=======================================
  Hits          876      876           
  Misses         65       65
Flag Coverage Δ
unittests 93.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvegayon gvegayon marked this pull request as ready for review August 16, 2024 17:56
damonbayer
damonbayer reviewed Aug 16, 2024
View reviewed changes
@damonbayer damonbayer self-requested a review August 16, 2024 18:15
damonbayer
damonbayer requested changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gvegayon Can you also update the installation instructions in getting_started?

@gvegayon
Copy link
Member Author

@gvegayon Can you also update the installation instructions in getting_started?

Good catch! Just did. Should be good now.

@gvegayon
Copy link
Member Author

Codecov is not uploading, so I'm guessing it's an issue on their side. All other test are passing.

@damonbayer
Copy link
Collaborator

@gvegayon Can you remove the pipeline github actions?

@damonbayer damonbayer self-requested a review August 20, 2024 15:06
@damonbayer
Copy link
Collaborator

@gvegayon Can you remove the pipeline github actions?

We will do this in a separate PR.

@damonbayer damonbayer merged commit e046337 into main Aug 20, 2024
9 checks passed
@damonbayer damonbayer deleted the ggvy-pyrenew-as-toplevel-project branch August 20, 2024 15:10
@dylanhmorris dylanhmorris mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonbayer damonbayer damonbayer approved these changes

@dylanhmorris dylanhmorris Awaiting requested review from dylanhmorris dylanhmorris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate pipeline from pyrenew
2 participants
@gvegayon @damonbayer