Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate pipeline from pyrenew #208

Closed
damonbayer opened this issue Jun 24, 2024 · 4 comments · Fixed by #388
Closed

Separate pipeline from pyrenew #208

damonbayer opened this issue Jun 24, 2024 · 4 comments · Fixed by #388
Labels
clean up Good code that could be better developer internal developer tooling pipeline

Comments

@damonbayer
Copy link
Collaborator

At this point, I think separating the pipeline from pyrenew only amounts to removing the nearly-empty pipeline folder and references to it in the readmes.

@AFg6K7h4fhy2
Copy link
Collaborator

Once the pipeline-description content is moved out of pipeline, do you have a vision for a more substantial pipeline folder (one that would make sense to have) to eventually exist, or do you see this been a lasting move to discontinue the pipeline folder?

@damonbayer
Copy link
Collaborator Author

I made this issue with the intention of removing the pipeline folder and eventually putting the pipeline in a separate repository, but I'm not completely committed to that plan. Regardless, we have no pipeline at the moment, so I don't see the point of having a pipeline folder.

@AFg6K7h4fhy2
Copy link
Collaborator

so I don't see the point of having a pipeline folder

Agree, for now.

but I'm not completely committed to that plan

There is probably a better way but something akin to what you have mentioned seems good.

@damonbayer
Copy link
Collaborator Author

Additional context: it now seems like there will be multiple models (Flu and Covid) using PyRenew, so I think those should probably be separate projects / repos. Having both those pipelines and the package code all in one repo seems messy.

@damonbayer damonbayer added clean up Good code that could be better developer internal developer tooling pipeline and removed development task labels Jul 12, 2024
@gvegayon gvegayon linked a pull request Aug 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Good code that could be better developer internal developer tooling pipeline
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants