Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNFT1-3307] event search feature flag #1922

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Oct 11, 2024

Description

Adds configurable front-end feature flags for searches;

Name Default Description
nbs.ui.features.search.events.enabled true Enables access to NBS6 Event Search
nbs.ui.features.search.investigations.enabled false Enables access to modernized Investigation search
nbs.ui.features.search.laboratoryReports.enabled false Enables access to modernized Laboratory search

Removed redundant configuration tests that were in modernization-api.

These configurations will be settable at deployment with changes made to the Helm charts.

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@adamloup-enquizit adamloup-enquizit force-pushed the CNFT1-3307-event-search-feature-flag branch from 930e7cd to db539ee Compare October 11, 2024 21:05
Copy link

@adamloup-enquizit adamloup-enquizit merged commit 07b6d5c into main Oct 14, 2024
2 checks passed
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-3307-event-search-feature-flag branch October 14, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants