[CNFT1-3307] Adds event search feature flags #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamloup-enquizit
requested review from
szamfir,
pvijay-enquizit,
njaved,
cmoss-enq,
tukhi,
kramakur and
a team
as code owners
9 tasks
szamfir
requested changes
Oct 28, 2024
| '--nbs.ui.features.patient.add.extended.enabled={{ (((((.Values).ui).patient).add).extended).enabled | default "false" }}', | ||
| '--nbs.ui.settings.smarty.key={{ .Values.ui.smarty.key }}', | ||
| '--nbs.ui.settings.analytics.key={{ .Values.ui.analytics.key }}' | ||
| '--nbs.ui.features.search.events.enabled={{ ((((.Values).ui).search).events).enabled }}', |
There was a problem hiding this comment.
There should be a default value for new and existing inputs that are required in values.yaml (the de facto release values file). Otherwise deployments may break in other environments.
There was a problem hiding this comment.
Made sure that boolean values have a default so that the service starts as expected. Will look into making blank values for boolean valid in the future
szamfir
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configurable feature flags for;
All three flags have been enabled for the INT1 environment. These changes can be merged ahead of the
modernization-apichanges that use these values.