Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cnft1 2748 extended create feature flag #1876

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Sep 26, 2024

Description

  1. Adds feature flag for extended patient create.
    a. Defaults to true for local dev.
    b. Defaults to false for deployed environment
  2. Removes configuration endpoint from open-api to prevent conflicting model generation

Dependencies

CDCgov/NEDSS-Helm#560

Tickets

Demo

Enabled

image

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

Copy link

Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpeels mpeels merged commit d3e69c6 into main Sep 26, 2024
3 checks passed
@mpeels mpeels deleted the CNFT1-2748-extended-create-feature-flag branch September 26, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants