Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended patient create feature flag #560

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Extended patient create feature flag #560

merged 3 commits into from
Sep 27, 2024

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Sep 26, 2024

Passes the extended patient create feature flag to the modernization-api container.

Default value will be false.

Set value to true in the int1 environment

@mpeels mpeels mentioned this pull request Sep 26, 2024
Merged
9 tasks
adamloup-enquizit
adamloup-enquizit previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🌟

szamfir
szamfir reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@szamfir szamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values.yaml is what we end up using for demo deployments and in our release zip. Should this value be set to false here until the feature is released pending testing?

szamfir
szamfir approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@szamfir szamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpeels mpeels merged commit 32a6101 into main Sep 27, 2024
2 checks passed
@mpeels mpeels deleted the extended-patient-feature-flag branch September 27, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szamfir szamfir szamfir approved these changes

@adamloup-enquizit adamloup-enquizit adamloup-enquizit left review comments

@pvijay-enquizit pvijay-enquizit Awaiting requested review from pvijay-enquizit pvijay-enquizit is a code owner

@njaved njaved Awaiting requested review from njaved njaved is a code owner

@cmoss-enq cmoss-enq Awaiting requested review from cmoss-enq cmoss-enq is a code owner

@tukhi tukhi Awaiting requested review from tukhi tukhi is a code owner

@kramakur kramakur Awaiting requested review from kramakur kramakur is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpeels @szamfir @adamloup-enquizit