Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config load bug #1821

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Config load bug #1821

merged 2 commits into from
Sep 17, 2024

Conversation

rkrusselenq
Copy link
Contributor

Description

Please include a summary of the changes and any key information a reviewer may need.

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@rkrusselenq rkrusselenq merged commit 3182a89 into case-dedup-ui Sep 17, 2024
1 check passed
@mpeels mpeels deleted the config-load-bug branch September 17, 2024 15:04
jlee-enquizit pushed a commit that referenced this pull request Sep 17, 2024
@rkrusselenq @jlee-enquizit
Config load bug (#1821)
7b0326c 
* init

* remove log
rkrusselenq added a commit that referenced this pull request Sep 17, 2024
@rkrusselenq @jlee-enquizit
@adamloup-enquizit @mpeels @hclarkEnq
Hydrate pass config form with existing data (#1824)
b0d5cb3 
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 18, 2024
@rkrusselenq @jlee-enquizit
Config load bug (#1821)
043c88d 
* init

* remove log
jlee-enquizit added a commit that referenced this pull request Sep 18, 2024
@rkrusselenq @jlee-enquizit
@adamloup-enquizit @mpeels @hclarkEnq
Hydrate pass config form with existing data (#1824)
a9c15d4 
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 19, 2024
@rkrusselenq @jlee-enquizit
Config load bug (#1821)
3160abd 
* init

* remove log
jlee-enquizit added a commit that referenced this pull request Sep 19, 2024
@rkrusselenq @jlee-enquizit
@adamloup-enquizit @mpeels @hclarkEnq
Hydrate pass config form with existing data (#1824)
7c527f3 
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 23, 2024
@rkrusselenq @jlee-enquizit
Config load bug (#1821)
e326ad8 
* init

* remove log
jlee-enquizit added a commit that referenced this pull request Sep 23, 2024
@rkrusselenq @jlee-enquizit
@adamloup-enquizit @mpeels @hclarkEnq
Hydrate pass config form with existing data (#1824)
aa55b63 
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 24, 2024
@rkrusselenq @jlee-enquizit
Config load bug (#1821)
e3b64e8 
* init

* remove log
jlee-enquizit added a commit that referenced this pull request Sep 24, 2024
@rkrusselenq @jlee-enquizit
@adamloup-enquizit @mpeels @hclarkEnq
Hydrate pass config form with existing data (#1824)
2f9fc8a 
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 25, 2024
@rkrusselenq @jlee-enquizit
Config load bug (#1821)
31386d5 
* init

* remove log
jlee-enquizit added a commit that referenced this pull request Sep 25, 2024
@rkrusselenq @jlee-enquizit
@adamloup-enquizit @mpeels @hclarkEnq
Hydrate pass config form with existing data (#1824)
3a78db5 
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamloup-enquizit adamloup-enquizit Awaiting requested review from adamloup-enquizit adamloup-enquizit is a code owner

@mpeels mpeels Awaiting requested review from mpeels mpeels is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rkrusselenq