Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNFT1-2939] List view sort options #1769

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Sep 6, 2024

Description

Ensures that the sort options for list view is closable via an "X" in the upper right corner.

image

  • Refactors the List sort options to use a custom component over ButtonActionMenu since these are not just buttons anymore.
  • Adds a ClosablePanel component to the design-system.
  • Changes the storage of sorting preferences to be specific to each type of search.
  • Fixes an overlay issue with the too ltip

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@adamloup-enquizit adamloup-enquizit marked this pull request as ready for review September 6, 2024 13:47
@hclarkEnq hclarkEnq merged commit b2dd397 into main Sep 6, 2024
1 check passed
mpeels pushed a commit that referenced this pull request Sep 6, 2024
* sorting preferences

* saving list sorting
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-2939-list-sort-options branch September 6, 2024 18:31
rkrusselenq pushed a commit that referenced this pull request Sep 10, 2024
* sorting preferences

* saving list sorting
rkrusselenq added a commit that referenced this pull request Sep 10, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 11, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 12, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 16, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 17, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
rkrusselenq added a commit that referenced this pull request Sep 17, 2024
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 18, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit added a commit that referenced this pull request Sep 18, 2024
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 19, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit added a commit that referenced this pull request Sep 19, 2024
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 23, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit added a commit that referenced this pull request Sep 23, 2024
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 24, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit added a commit that referenced this pull request Sep 24, 2024
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit pushed a commit that referenced this pull request Sep 25, 2024
* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
jlee-enquizit added a commit that referenced this pull request Sep 25, 2024
* init (#1747)

* Cnft2 2763 data elements table setup (#1754)

* styling (#1762)

* Empty layouts for dedup (#1767)

* init

* remaining styling

* fix conflicts

* adds mock configuration list and functionality (#1771)

* Data Elements Table rows (#1776)

* CNFT2-2767 Error tooltips (#1786)

* Pass config init layout (#1784)

* [FIX] Patient sorting (#1766)

* local environment

* adds support for legalname sorting

* Clear county when state value is cleared. Hook error fix (#1756)

* Clear county when state value is cleared. Hook error fix

* Make better

---------

Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>

* [CNFT1-2939] List view sort options (#1769)

* sorting preferences

* saving list sorting

* passing down size prop (#1773)

* init

* fix linting

---------

Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>

* CNFT2-2768 Data Elements submit, redirect, context updates (#1791)

* CNFT2-2769 Patient Match refactor (#1802)

* Store data elements locally (#1805)

* init

* fix merge

* more unexplainable conflicts

* init (#1806)

* CNFT2-2770 Blocking Criteria modal, Form setup (#1808)

* CNFT2-2771 Blocking criteria rows (#1810)

* Move types (#1812)

* init

* add pass config type

* Configure pass config fetch (#1815)

* init

* add saving

* CNFT2-2772 Matching Criteria section (#1819)

* Config load bug (#1821)

* init

* remove log

* init

---------

Co-authored-by: John Lee <124739504+jlee-enquizit@users.noreply.github.com>
Co-authored-by: Adam Loup <124325935+adamloup-enquizit@users.noreply.github.com>
Co-authored-by: Michael Peels <109251240+mpeels@users.noreply.github.com>
Co-authored-by: Michael Peels <michaelpeels@Michael-Peels.local>
Co-authored-by: Henry Clark <111446161+hclarkEnq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants