Disable sliders #428
Disable sliders #428
Conversation
test_export_html.ipynb
Outdated
| }, | ||
| "nbformat": 4, | ||
| "nbformat_minor": 2 | ||
| } |
tests/test_vcs_export_html.py
Outdated
| @@ -0,0 +1,59 @@ | |||
| import os | |||
There was a problem hiding this comment.
Is this file the best way to test that the html displays the plots properly?
| f = open(tmp, "rb") | ||
| st = f.read() | ||
| f.close() | ||
| self._parent._display_target_image.value = st |
There was a problem hiding this comment.
I don't think we need this line outside of the SLIDERS_ENABLED section above.
|
Will squash commits before merging. |
tests/test_vcs_export_html.py
Outdated
| debug_print('Run the notebook') | ||
| # This is apparently NOT equivalent to running the notebook on the web. | ||
| # Generating the HTML this way keeps the plot, whereas running from the web does not. | ||
| assert os.system('jupyter nbconvert --to notebook --execute ../test_export_html.ipynb') == 0 |
There was a problem hiding this comment.
Circle CI apparently expects a different file path.
|
@forsyth2 please pull the code in master to your branch, your branch's .circleci/config.yml is outdated which is why it is failing in circleci. |
forsyth2
force-pushed
the
disable-sliders
branch
from
797c644 to
88c58cf
Compare
forsyth2
force-pushed
the
disable-sliders
branch
from
88c58cf to
e716f99
Compare
.circleci/config.yml
Outdated
| if [[ $CIRCLE_BRANCH != "master" ]]; then | ||
| exit 0 | ||
| fi | ||
| #if [[ $CIRCLE_BRANCH != "master" ]]; then |
There was a problem hiding this comment.
Revert changes in this file before merging.
There was a problem hiding this comment.
Looks like you need to revert these changes?
|
@downiec @muryanto1 Ready for review. I will revert the second commit before merging. |
.circleci/config.yml
Outdated
| if [[ $CIRCLE_BRANCH != "master" ]]; then | ||
| exit 0 | ||
| fi | ||
| #if [[ $CIRCLE_BRANCH != "master" ]]; then |
There was a problem hiding this comment.
Looks like you need to revert these changes?
forsyth2
force-pushed
the
disable-sliders
branch
from
937d0dc to
e716f99
Compare
Disabling sliders until we can implement them properly. This resolves #424 and replaces #426. Tests are in CDAT/jupyter-vcdat#154