Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sliders #426

Closed
wants to merge 1 commit into from
Closed

Disable sliders #426

wants to merge 1 commit into from

Conversation

forsyth2
Copy link
Contributor

@forsyth2 forsyth2 commented Dec 9, 2019

Disabling sliders until we can implement them properly. This resolves #424.

@forsyth2
Copy link
Contributor Author

forsyth2 commented Dec 9, 2019

The only real changes are in displayplot.py. TestNotebook is just for testing and will be removed before merging.

I will install jupyter-vcdat locally to further testing.

@forsyth2 forsyth2 requested review from downiec and muryanto1 December 9, 2019 22:16
f = open(tmp, "rb")
st = f.read()
f.close()
self._parent._display_target_image.value = st
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this line outside of the SLIDERS_ENABLED section above.

This was referenced Dec 9, 2019
@forsyth2
Copy link
Contributor Author

Circle CI tests may be failing because this pull request is from a fork, not the CDAT/vcs repo itself. Replacing with #428

@forsyth2
Copy link
Contributor Author

Closing in favor of #428

@forsyth2 forsyth2 closed this Jan 13, 2020
@downiec downiec modified the milestones: 8.2, 8.2.1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

downloading a jupyter notebook has html does not have the image/plot included
2 participants