Make new destination slice when length doesn't match. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 just ran into this too, thank you @mrdg Any chance we can merge this in @BurntSushi ? |
|
Yes please! This is very useful if you want to unmarshal into a slice type that you've populated with default values. encoding/json lets you do this. |
|
This bit me today. Please merge this fix (or fix it otherwise). |
|
I want to use this. Would you merge it? |
| @@ -308,7 +308,7 @@ func (md *MetaData) unifySlice(data interface{}, rv reflect.Value) error { | |||
| return badtype("slice", data) | |||
| } | |||
| sliceLen := datav.Len() | |||
| if rv.IsNil() { | |||
| if rv.IsNil() || rv.Len() != datav.Len() { | |||
There was a problem hiding this comment.
Instead you might want to only do this if rv.Cap() < datav.Len() and otherwise rv.SetLen(datav.Len()). But it's an optimization that probably doesn't matter for most TOML use cases.
|
@BurntSushi bump. This fix is ready to go. |
|
please release! |
|
Merged, thanks! I made the change I mentioned in 0c4ce10. |
This was referenced Feb 23, 2016
jsternberg
added a commit
to influxdata/influxdb
that referenced
this pull request
Feb 23, 2016
The bug was fixed by BurntSushi/toml#84. Also adding gdm install to `make tools`.
|
thanks!! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83