Overwrite existing slices when unmarshaling #105
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the behavior inline with that of the standard library (eg.
encoding/json). This does change the behavior when the second slice is smaller (eg. before a new slice with 1 element would have overwritten just the first element of the existing slice, now you end up with a new slice). I think this is what most users will expect though (especially since it's what
encoding/json
and the like do).Fixes #49
Fixes #99
Eg. the following now works (which would have produced a panic before):
Output: