-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Program Identifier to Support Other Projects #58
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
26c5739
Initial draft of proposal
jasondegraw 06d8ce2
Merge branch 'develop' into propose-audit-to-project
nllong f3d5a0b
Merge branch 'develop' into propose-audit-to-project
nllong b69fc11
update proposal to remove renaming audit since that is handled in ano…
nllong a2d9a57
New Implementation
spanziera de1b74a
Merge branch 'develop' into propose-audit-to-project
nllong c634ac5
Merge branch 'develop' into propose-audit-to-project
nllong 6fd1619
Merge branch 'develop' into propose-audit-to-project
nllong 97a5ceb
updated proposal w Facility
aqwolfe aec89fe
added program elements to .xsd
aqwolfe 5989739
update program .xsd + an example .xml
aqwolfe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# Changes to Support Other Project Types # | ||
|
||
## Overview ## | ||
The BuildingSync schema can be useful and leveraged for more types of project than just audits, and the current schema uses an audit element that can be confusing. After changing the root element to not be Audit, this proposal will add information to help identify the BuildingSync instance. | ||
|
||
## Justification ## | ||
A few relatively small changes are proposed to better support other cases. The proposed BuildingSync element names have been reviewed by LBNL BEDES team so that they use BEDES compliant terms and structure. | ||
|
||
## Implementation ## | ||
The proposed implementation is to add the elements marked with a '*' to the BuildingSync.xsd code: | ||
>BuildingSync/ | ||
oPrograms/* | ||
-Program/* | ||
+ProgramDate* | ||
+ProgramFundingSource* | ||
+ProgramClassification* | ||
oCampuses/Campus/ | ||
Note that this root element sequence refers to the one explained in Proposal #64. | ||
|
||
Steps: | ||
a)Create an element named 'Programs' as a sibling of 'Campuses.' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Facility |
||
b)Create an element named 'Program' as a child of 'Programs.' | ||
c)Create the elements 'ProgramDate,' 'ProgramFundingSource,' and 'Program Classification' as children of 'Program.' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Program Classification -> ProgramClassification |
||
d)Add the BEDES definition of each BEDES term used as a description of the mentioned elements. | ||
|
||
|
||
## References ## | ||
Site used to research BEDES terms: https://bedes.lbl.gov/bedes-online |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be facilities/facilty