Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Program Identifier to Support Other Projects #58

Merged
merged 11 commits into from
Jan 30, 2019

Conversation

jasondegraw
Copy link
Contributor

The BuildingSync schema can be useful and leveraged for more types of project than just audits, and the current schema uses an audit element that can be confusing.

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of this change. We will need to socialize this widely and gather other user input.

@nllong nllong mentioned this pull request Dec 11, 2018
@nllong nllong changed the title Proposal to Change Audit to Support Other Projects Add Program Identifier to Support Other Projects Jan 3, 2019
@nllong
Copy link
Member

nllong commented Jan 9, 2019

Implement this after #64 is merged down.

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments. Looks good to get started!

+ProgramDate*
+ProgramFundingSource*
+ProgramClassification*
oCampuses/Campus/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be facilities/facilty

Note that this root element sequence refers to the one explained in Proposal #64.

Steps:
a)Create an element named 'Programs' as a sibling of 'Campuses.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facility

Steps:
a)Create an element named 'Programs' as a sibling of 'Campuses.'
b)Create an element named 'Program' as a child of 'Programs.'
c)Create the elements 'ProgramDate,' 'ProgramFundingSource,' and 'Program Classification' as children of 'Program.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Program Classification -> ProgramClassification

@aqwolfe
Copy link
Contributor

aqwolfe commented Jan 29, 2019

@nllong there is not an example file using the program element, do you want me to modify an existing example? if so should that be a new example or just a new version of existing example?

@nllong
Copy link
Member

nllong commented Jan 29, 2019 via email

updated program .xsd so that simpletype is referenced and adjusted program element attributes
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nllong nllong merged commit 01b21cd into develop Jan 30, 2019
@nllong nllong deleted the propose-audit-to-project branch January 30, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants