Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only configure publisher confirmation callbacks once [v9] #3256

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Only configure publisher confirmation callbacks once [v9] #3256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/Paramore.Brighter/CommandProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,6 @@ public CommandProcessor(IAmARequestContextFactory requestContextFactory,
_transformPipelineBuilder = new TransformPipelineBuilder(mapperRegistry, messageTransformerFactory);

InitExtServiceBus(policyRegistry, outBox, outboxTimeout, producerRegistry, outboxBulkChunkSize);

ConfigureCallbacks(producerRegistry);
}

/// <summary>
Expand Down Expand Up @@ -220,8 +218,6 @@ public CommandProcessor(IAmASubscriberRegistry subscriberRegistry,
_transformPipelineBuilder = new TransformPipelineBuilder(mapperRegistry, messageTransformerFactory);

InitExtServiceBus(policyRegistry, outBox, outboxTimeout, producerRegistry, outboxBulkChunkSize);

ConfigureCallbacks(producerRegistry);
}

/// <summary>
Expand Down Expand Up @@ -261,8 +257,6 @@ public CommandProcessor(IAmASubscriberRegistry subscriberRegistry,
_transformPipelineBuilder = new TransformPipelineBuilder(mapperRegistry, messageTransformerFactory);

InitExtServiceBus(policyRegistry, outBox, outboxTimeout, producerRegistry, outboxBulkChunkSize);

ConfigureCallbacks(producerRegistry);
}

/// <summary>
Expand Down Expand Up @@ -815,8 +809,7 @@ private void AssertValidSendPipeline<T>(T command, int handlerCount) where T : c
$"No command handler was found for the typeof command {typeof(T)} - a command should have exactly one handler.");
}


private void ConfigureCallbacks(IAmAProducerRegistry producerRegistry)
private static void ConfigureCallbacks(IAmAProducerRegistry producerRegistry)
{
//Only register one, to avoid two callbacks where we support both interfaces on a producer
foreach (var producer in producerRegistry.Producers)
Expand Down Expand Up @@ -871,6 +864,8 @@ private static void InitExtServiceBus(
_bus.PolicyRegistry = policyRegistry;
_bus.ProducerRegistry = producerRegistry;
_bus.OutboxBulkChunkSize = outboxBulkChunkSize;

ConfigureCallbacks(producerRegistry);
}
}
}
Expand Down
Loading