Only configure publisher confirmation callbacks once [v9] #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bus initialisation
dhickie
requested review from
iancooper,
holytshirt,
DevJonny and
preardon
as code owners
iancooper
approved these changes
Aug 13, 2024
preardon
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3246 by ensuring that publish confirmation delegates are only registered once. It does this in a slightly different way than the one that was suggested in the issue, as I noticed that v10 fixes this by moving the callback registration to inside the
ExternalBusServicesconstructor. In v9ExternalBusServicesdoesn't have an explicit constructor, so I've moved the call toConfigureCallbacksto inside the lock where the static instance is initialised inCommandProcessor.