[BI-998] - Add tags to traits #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,4 +104,37 @@ export class Trait { | |||
| (!this.method && !trait.method) | |||
| ); | |||
| } | |||
|
|
|||
| addTag(tag: string) { | |||
There was a problem hiding this comment.
Would these be cleaner to manage in a set or is there a problem with the Vue data updates when doing that?
There was a problem hiding this comment.
Yeah that's a good point. I think Vue can handle sets, I'll give it a try.
There was a problem hiding this comment.
Vue can handle sets, but the buefy autocomplete component can't. I'm going to keep this as an array.
added 5 commits
July 28, 2021 16:18
dmeidlin
approved these changes
Jul 29, 2021
nickpalladino
approved these changes
Aug 2, 2021
| @@ -32,7 +32,7 @@ | |||
| <div class="level-item"> | |||
| <div class="has-text-dark has-text-centered is-size-7"> | |||
| <!-- temporary link until the backend card is done --> | |||
| <a href="https://cornell.box.com/shared/static/snf69ydrzmmr27qfqby0pcr0mw34qulr.xls" | |||
| <a href="https://cornell.box.com/shared/static/g6vmpktevwolwkyatwxbdbzpkbwv77ov.xls" | |||
There was a problem hiding this comment.
How is tags different from trait lists?
timparsons
pushed a commit
that referenced
this pull request
Sep 29, 2021
[BI-998] - Add tags to traits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See other PRs for this feature:
brapi: Breeding-Insight/brapi#40
bi-api: Breeding-Insight/bi-api#95
sgn: Breeding-Insight/sgn#30
Screen shots: