[BI-998] - Add tags to traits #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,13 +56,17 @@ | |||
| @Property(name = "brapi.server.reference-source") | |||
| private String referenceSource; | |||
| private ObservationDAO observationDao; | |||
| private Gson gson; | |||
|
|
|||
| private String TAGS_KEY = "tags"; | |||
| @@ -36,7 +36,8 @@ | |||
| SCALE_DECIMAL_PLACES("Scale decimal places"), | |||
| SCALE_LOWER_LIMIT("Scale lower limit"), | |||
| SCALE_UPPER_LIMIT("Scale upper limit"), | |||
| SCALE_CATEGORIES("Scale categories"); | |||
| SCALE_CATEGORIES("Scale categories"), | |||
| TAGS("Tags"); | |||
There was a problem hiding this comment.
How is tags different from trait lists?
| @@ -59,6 +59,8 @@ | |||
| private DSLContext dsl; | |||
| private TraitValidatorError traitValidatorError; | |||
|
|
|||
| private String FAVORITES_TAG = "favorites"; | |||
| } | ||
| } | ||
|
|
||
| tags.add(FAVORITES_TAG); |
There was a problem hiding this comment.
What is the purpose of this favorites tag?
There was a problem hiding this comment.
There should always be a favorites tag as an option. This sends the favorites tag back in the options of tags even if a trait isn't assigned that tag yet.
added 7 commits
July 28, 2021 11:59
nickpalladino
approved these changes
Jul 28, 2021
dmeidlin
approved these changes
Jul 29, 2021
timparsons
pushed a commit
that referenced
this pull request
Sep 29, 2021
[BI-998] - Add tags to traits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests fail right now because tags were added and the brapi-server needs to be patched. This can still be review before then, I won't merge until the tests pass.
Uses the brapi
variable.additionalInfofield to store the tags.Additions:
Notes:
See other PRs for this feature:
brapi: Breeding-Insight/brapi#40
sgn: Breeding-Insight/sgn#30
bi-web: Breeding-Insight/bi-web#99
LEFT TO DO: