[BI-684, BI-682] - Calendar scale and Computation method class #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timparsons
approved these changes
Dec 9, 2020
ctucker3
force-pushed
the
feature/BI-684
branch
from
ce4c430 to
2d175ed
Compare
| this.trait.scale!.categories = undefined; | ||
| } | ||
|
|
||
| setScaleClass(value: string) { |
There was a problem hiding this comment.
Is the state of ordinal and nominal supposed to be shared with each other? Looks like now they each keep their own state.
There was a problem hiding this comment.
I left it out because I wanted to limit the logic on the UI and it would be one more thing to maintain. But, it is part of the requirements, so I added it in. Thanks for the catch!
nickpalladino
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the calendar scale class and the computation method class. Also added a history to the scale classes and the method formula.