[BI-671,BI-679] - Create new trait - Scale class 'ordinal scale' and Scale class 'nominal class' #60
Conversation
ctucker3
force-pushed
the
feature/BI-671
branch
from
39c6d6a to
a952806
Compare
ctucker3
force-pushed
the
feature/BI-671
branch
from
85f43b3 to
2b0cf29
Compare
ctucker3
changed the title
| <template v-if="trait.scale && trait.scale.dataType === DataType.Nominal"> | ||
| <CategoryTraitForm | ||
| v-on:update="trait.scale.categories = $event" | ||
| v-bind:type="DataType.Nominal" | ||
| /> |
There was a problem hiding this comment.
This element and Ordinal could be combined. The type passed to CategoryTraitForm can be the value of trait.scale.dataType
There was a problem hiding this comment.
Good catch. This is changed in one of the next PR's I have open.
| v-bind:type="DataType.Ordinal" | ||
| /> | ||
| </template> | ||
| <template v-if="trait.scale && trait.scale.dataType === DataType.Text"> |
There was a problem hiding this comment.
There's also a method to do a case insensitive comparison for the DataType in the Scale class. Not important here since it's a new trait but may be for edit where that info could possibly come in differently.
There was a problem hiding this comment.
Ok, that might be good to check. I was thinking that those data types got transformed into the enum values which is why I didn't worry about case matching. I'll leave that for the edit form card if that is cool with you?
No description provided.