Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1615] - Add termType to Trait DB Table #285

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Dec 5, 2022

Description

Story: BI-1615 - Add termType to Trait DB Table

NOTE: This is forked from BI-1614, so changelist will include changes from there until BI-1614 is merged into develop

Small improvements off BI-1614 to ensure term types actually display
Created EnumUtils to handle methods for converting between enum key and value for ease of converting between the user-friendly display value and the backend storage value, and utilized them for term types

NOTE: Sorting could get weird if the alphabetical order differs between the user friendly display (ie Germplasm Passport) and backend storage value (GERM_PASSPORT). Not a problem here, but something to keep in mind. Also the difference between display and backend and the fact that there are a few distinct types means that if filtering was to be implemented for term types in the future it should probably be via drop down rather than text box.

Dependencies

bi-api/BI-1615

Testing

  • Open ontology table
  • Check that Term Type column exists and is populated with values
  • Check that Term Type column can be sorted
  • Click new term, check that there is now a Term Type dropdown with "Phenotype" as default and a dropdown that lists "Phenotype", "Germplasm Attribute", and "Germplasm Passport"
  • Select term type and save, check that new ontology term displayed in table with correct term type
  • Click 'Show Details' for one germplasm, check side panel display includes Term Type and Term Type is correct value
  • Click edit term, check that Term Type dropdown value matches the Term Type in table
  • Change Term Type and check that new value is saved and displayed correctly in table
  • Check that Term Type column also exists in Archived Ontology table and not just Active

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@HMS17 HMS17 requested review from a team, timparsons, dmeidlin and davedrp and removed request for a team and timparsons December 6, 2022 16:12
@HMS17 HMS17 marked this pull request as ready for review December 6, 2022 16:13
Copy link
Contributor

@dmeidlin dmeidlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All features work as expected. The "Term Type" field in both the edit and new ont. term forms has an asterisk (denoting required field) and is listed at the top above the Name and Description fields. While the frontend and backend checks should stay in place, the asterisk is superfluous and should be removed since the dropdown prevents inputing unsupported or null values. Also, the Term Type field should be below the Description field and above the synonym field to be more consistent with the order of the fields in the details summary and table column headings.

@nickpalladino nickpalladino merged commit 3b9a58a into develop Jan 18, 2023
@nickpalladino nickpalladino deleted the feature/BI-1615 branch January 18, 2023 18:56
@nickpalladino nickpalladino restored the feature/BI-1615 branch January 18, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants