Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1614] - Add Term Type to Ontology Term display and form #284

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Nov 30, 2022

Description

Story: BI-1614 - Add Term Type to Ontology Term display and form creation/modification

Added TermType enum and added dropdown to select Term Type in ontology term form.
Added display of term type in ontology side panel and ontology table

Dependencies

bi-api/develop

Testing

NOTE: As Term Type is not yet stored in backend, table/side panel display will need to be tested in BI-1615

  • Navigate to ontology table
  • Should see empty Term Type column
  • Select new term
  • New input Term Type should be present at top of form, with a dropdown and "Phenotype" selected as default.
  • Dropdown should list the options "Phenotype", "Germplasm Attribute", and "Germplasm Passport"
  • User should be able to select aforementioned options
  • Click edit on existing ontology term, Term Type should be present at top of form with same dropdown

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@HMS17 HMS17 requested review from a team, timparsons, nickpalladino and davedrp and removed request for a team and timparsons November 30, 2022 18:49
@HMS17 HMS17 marked this pull request as ready for review November 30, 2022 19:08
@davedrp davedrp assigned davedrp and unassigned nickpalladino Dec 7, 2022
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy path testing - Passed

@HMS17 HMS17 merged commit d60d704 into develop Dec 8, 2022
@HMS17 HMS17 deleted the feature/BI-1614 branch December 8, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants