Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BI-1411 - Ontology: Switching to Numerical class during edit populates units with “Numerical” #209

Merged
merged 30 commits into from
Apr 1, 2022
Merged

BI-1411 - Ontology: Switching to Numerical class during edit populates units with “Numerical” #209

merged 30 commits into from
Apr 1, 2022

Conversation

nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Mar 17, 2022 •
edited
Loading

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1411?atlOrigin=eyJpIjoiNjMzNTdkYTFkMjY4NDk5Y2EwMGEzMGZiZjc0Mzk4YTUiLCJwIjoiaiJ9

  • Added check for numerical scale history

Dependencies

  • biapi develop branch

Testing

  • Verify that the units field keeps the last value entered for numerical and does not populate with Numerical

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

HMS17 and others added 15 commits March 10, 2022 14:31
@nickpalladino nickpalladino changed the base branch from develop to release/0.5 March 17, 2022 18:16
@nickpalladino nickpalladino requested review from a team, dmeidlin and ctucker3 and removed request for a team March 21, 2022 19:28
@nickpalladino nickpalladino merged commit f80efc2 into release/0.5 Apr 1, 2022
@nickpalladino nickpalladino deleted the bug/BI-1411 branch April 1, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctucker3 ctucker3 ctucker3 approved these changes

@dmeidlin dmeidlin dmeidlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickpalladino @dmeidlin @ctucker3 @HMS17 @rob-ouser-bi