BI-1404 - No loading wheel ontology page #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpalladino
requested review from
a team,
davedrp and
ctucker3
and removed request for
a team
ctucker3
suggested changes
Mar 14, 2022
| } | ||
| }).catch((error) => { | ||
| // Display error that traits cannot be loaded | ||
| this.$emit('show-error-notification', 'Error while trying to load traits'); | ||
| this.traitsLoading = false; |
There was a problem hiding this comment.
The two this.traitsLoading = false could be put into one finally statement.
davedrp
approved these changes
Mar 15, 2022
ctucker3
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1404
Dependencies
Testing
Checklist: