Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1086] - Germplasm lists table #169

Merged
merged 15 commits into from
Jan 24, 2022
Merged

[BI-1086] - Germplasm lists table #169

merged 15 commits into from
Jan 24, 2022

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Jan 13, 2022

Description

Story: BI-1086 - Germplasm lists table

Changes to display a table of Germplasm Lists

  • Created GermplasmLists.vue and GermplasmListsTable.vue components to retrieve and display a table of germplasm lists
  • Created GermplasmService.ts and GermplasmDAO.ts to call GET /lists endpoint and handle pagination
  • Updated navigation to direct to newly created Germplasm Lists component

Dependencies

bi-api/BI-1086

Testing

Location
Open program, ensure that Germplasm Lists menu item under Germplasm and when clicked navigates to Germplasm Lists table

No germplasm
Create/open program with no germplasm
Navigate to Germplasm Lists and ensure that table is empty and message "Germplasm lists not yet specified." present

Germplasm
Use importer to import germplasm (ie BI-1056_lots_of_germplasm.xls)
Navigate to Germplasm Lists and ensure germplasm list is displayed in table with correct name, description, total entries, and date created. Ensure that nonfunctional download link also present.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF.

@HMS17 HMS17 marked this pull request as ready for review January 14, 2022 17:00
@HMS17 HMS17 requested review from a team, davedrp and dmeidlin and removed request for a team January 14, 2022 17:00
@HMS17 HMS17 requested a review from dmeidlin January 24, 2022 14:18
@HMS17 HMS17 merged commit f84cfc9 into develop Jan 24, 2022
@HMS17 HMS17 deleted the feature/BI-1086.1 branch January 24, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants