Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1086] - Germplasm lists table #136

Merged
merged 9 commits into from
Jan 24, 2022
Merged

[BI-1086] - Germplasm lists table #136

merged 9 commits into from
Jan 24, 2022

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Jan 13, 2022

Description

Story: BI-1086 - Germplasm lists table

Backend updates to retrieve Germplasm Lists from GET /lists endpoint

  • Created method in BrAPIV2Controller for GET /lists endpoint
  • Updated BrAPIGermplasmService.java to support retrieval of germplasm lists
  • Added getListByTypeAndExternalRef to BrAPIListDAO.java to retrieve germplasm-specific lists associated with a particular program
  • Added unit test to GermplasmControllerIntegrationTest.java

Dependencies

bi-web/BI-1086

Testing

See testing for bi-web/BI-1086

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF.

@HMS17 HMS17 requested review from davedrp and dmeidlin January 14, 2022 17:01
@HMS17 HMS17 marked this pull request as ready for review January 14, 2022 17:03
@davedrp davedrp assigned HMS17 and unassigned davedrp Jan 20, 2022
@davedrp
Copy link
Contributor

davedrp commented Jan 20, 2022

In the Germplasm List tab the system is retrieving all germplasm lists, not just the ones associated with the program.

@HMS17 HMS17 assigned davedrp and unassigned HMS17 Jan 20, 2022
@HMS17
Copy link
Contributor Author

HMS17 commented Jan 20, 2022

In the Germplasm List tab the system is retrieving all germplasm lists, not just the ones associated with the program.

Resolved, was an issue compiling some of the bi-api files

@HMS17 HMS17 merged commit 7d76eb3 into develop Jan 24, 2022
@HMS17 HMS17 deleted the feature/BI-1086.1 branch January 24, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants