Move Before prepare and After prepare hooks to after plugin install, add #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all, add This fixes the bug mentioned here: #333
|
Thank you for contributing. This pull request passed all my test devices. Please email me at eneff@branch.io. I would love to give you a free t-shirt for helping me out. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix the bug mentioned in #333
When you remove platforms and plugins folder and do cordova prepare -> hooks would be executed in below order.
==before_prepare
adds platforms
==after_prepare
detects config.xml plugins
==before_plugin_add
==before_plugin_install
installs the plugin
==after_plugin_install
==after_plugin_add
So based on the above flow, code in after_prepare and before_prepare hooks in the plugin will not be executed if you do a cordova prepare on clean slate env.