Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associated domain capabilities not copied to Xcode #333

Closed
imrvshah opened this issue Jun 13, 2017 · 3 comments
Closed

Associated domain capabilities not copied to Xcode #333

imrvshah opened this issue Jun 13, 2017 · 3 comments

Comments

@imrvshah
Copy link

Hi,

When I do cordova prepare or yarn cordova:reset or ionic reset state does not copy the links to Associated Domains but when I do ionic build ios it does copy links.

So, can we copy that when we do yarn cordova:reset ?

@ethanneff
Copy link
Contributor

Hello Ravi,

Right now our hooks to generate the Associated Domain are on before_prepare (code). I will investigate if I can add theses hooks to yarn cordova:reset as well.

A little forewarning, it will probably be a week before I can get this implemented as I'm limited on bandwidth as I'm the moment.

Thanks,

@harshabonthu
Copy link
Contributor

harshabonthu commented Jun 14, 2017

I was able to replicate this bug using below steps:-

Cordova version: 6.5.0

Create new cordova project
cordova create branchbug && cd branchbug

Add iOS platform
cordova platform add ios --save

Add branch plugin i.e copy below to config.xml

    <plugin name="branch-cordova-sdk" spec="../cordova-ionic-phonegap-branch-deep-linking" />
    <branch-config>
        <branch-key value="key_live_ndqptlgXNE4LHqIahH1WIpbiyFlb62J3" />
        <uri-scheme value="branchcordova" />
        <link-domain value="cordova.app.link" />
        <ios-team-release value="PW4Q8885U7" />
    </branch-config>

Now to replicate blank slate env or new machine setup

  • Delete platforms and plugins folders and do cordova prepare
    rm -rf platforms && rm -rf plugins && cordova prepare

Now open xcode project and check the capabilities section

  • Result: Associate domain capabilities are not enabled
  • Expected: Associate domain capabilities should be enabled

@ethanneff
Copy link
Contributor

I merged @harshabonthu's pull request.

@imrvshah can you please update Branch to the latest SDK version to fix this issue?

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants