Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-644] Add optional zip code to checkout cart #17

Merged
merged 1 commit into from
Jan 12, 2023
Merged

[API-644] Add optional zip code to checkout cart #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/cart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ class Cart extends Node<Graph.Cart> {
cvv: string;
exp_month: number;
exp_year: number;
address_postal_code?: string;
};
}
| { token: string },
Expand Down Expand Up @@ -364,6 +365,7 @@ class Cart extends Node<Graph.Cart> {
cvv: string;
exp_month: number;
exp_year: number;
address_postal_code?: string;
};
}
| { token: string }
Expand Down
2 changes: 1 addition & 1 deletion tests/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { Location } from "../src/locations";
import { createHmac } from "crypto";

const businessId = "63b60ecb-6d1e-4bb6-87ad-3cb52ffe09b4";
const apiKey = process.env.SANDBOX_API_KEY;
const apiKey = process.env.SANDBOX_API_KEY!;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen process.env with a bang, does that make it required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, kinda, it unfortunately only works at the type level so won't actual throw a runtime exception.

const anon = new Blvd(apiKey, businessId);

describe("appointments", () => {
Expand Down