[API-644] Add optional zip code to checkout cart #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opsb
temporarily deployed
to
integration-sandbox
GitHub Actions
Inactive
opsb
temporarily deployed
to
integration-sandbox
GitHub Actions
Inactive
opsb
temporarily deployed
to
integration-sandbox
GitHub Actions
Inactive
opsb
temporarily deployed
to
integration-sandbox
GitHub Actions
Inactive
tfiedlerdejanze
approved these changes
Jan 12, 2023
| @@ -17,7 +17,7 @@ import { Location } from "../src/locations"; | |||
| import { createHmac } from "crypto"; | |||
|
|
|||
| const businessId = "63b60ecb-6d1e-4bb6-87ad-3cb52ffe09b4"; | |||
| const apiKey = process.env.SANDBOX_API_KEY; | |||
| const apiKey = process.env.SANDBOX_API_KEY!; | |||
There was a problem hiding this comment.
Never seen process.env with a bang, does that make it required?
There was a problem hiding this comment.
It does, kinda, it unfortunately only works at the type level so won't actual throw a runtime exception.
opsb
temporarily deployed
to
integration-sandbox
GitHub Actions
Inactive
opsb
force-pushed
the
api-644/add-zip-code-to-checkout
branch
from
33ca287 to
bf05859
Compare
opsb
temporarily deployed
to
integration-sandbox
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facilitates https://github.com/Boulevard/abundant-booking-flow/pull/73
Adds
address_postal_codeas an optional property on theaddCardPaymentMethodmutation. Vault is already familiar with the property and will use it during processing if available.