Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc updates #124

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Misc updates #124

wants to merge 9 commits into from

Commits on Sep 11, 2023

  1. Bump minimum CMake verison to 3.25. 

    Support for versions <= 3.5 will be dropped soon. Current Debian stable
has 3.25, so a good candidate.
    @perezmeyer
    perezmeyer committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    80d7eae View commit details
    Browse the repository at this point in the history

  2. Replace depreceated endl with Qt::endl.

    @perezmeyer
    perezmeyer committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d5eb71a View commit details
    Browse the repository at this point in the history

  3. Replace deprecated calls on QByteArray::append(const QString &str) 

    These should now be explicit on the type. My guess here is that Latin1
will do.
    @perezmeyer
    perezmeyer committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    df15174 View commit details
    Browse the repository at this point in the history

  4. Solve possible dangling reference warning by using auto. 

    Let the compiler (hopefully) do the right thing.
    @perezmeyer
    perezmeyer committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6908d3c View commit details
    Browse the repository at this point in the history

  5. Add extra formats supported in Qt >= 5.14.

    @perezmeyer
    perezmeyer committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b73a0ad View commit details
    Browse the repository at this point in the history

  6. Fix typo when adding Qt::endl.

    @perezmeyer
    perezmeyer committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    bf5e1dc View commit details
    Browse the repository at this point in the history

  7. Replace deprecated QString:: namespace for Qt::.

    @perezmeyer
    perezmeyer committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c284266 View commit details
    Browse the repository at this point in the history

  8. Resolve possible dangling reference by using auto.

    @perezmeyer
    perezmeyer committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    deabdfa View commit details
    Browse the repository at this point in the history

  9. Issue a warning instead of crashing. 

    This throw was not being catched, better issue a warning instead.
    @perezmeyer
    perezmeyer committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    9a7059b View commit details
    Browse the repository at this point in the history