Misc updates #124
Draft
Misc updates #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for versions <= 3.5 will be dropped soon. Current Debian stable has 3.25, so a good candidate.
These should now be explicit on the type. My guess here is that Latin1 will do.
Let the compiler (hopefully) do the right thing.
This throw was not being catched, better issue a warning instead.
|
By the way, this is a draft PR because I am mostly showcasing changes. Ideally one should check each commit on it's own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SokoloffA I understand you don't have much time (if any) for this project. I am willing to put some effort on it, so here I prepared some changes I would do. I am also thinking in trying to get the new poppler API up and running and supporting Qt 6.
Do you think there is a way in which I could help?