Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmodl, sympy: bump sympy version #2508

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

nmodl, sympy: bump sympy version #2508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b75b10
nmodl: bump sympy version
JCGoran Sep 2, 2024
e7595a1
sympy: add version 1.13.0
JCGoran Sep 2, 2024
d20b8a8
sympy: update deps
JCGoran Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bluebrain/repo-bluebrain/packages/nmodl/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class Nmodl(CMakePackage):
depends_on("python@3.6.0:")
depends_on("py-jinja2@2.10:", type=("build", "run"))
depends_on("py-pybind11", type=("build", "link", "run"))
depends_on("py-sympy@1.3:", type=("build", "run"))
depends_on("py-sympy@1.13:", type=("build", "run"))
depends_on("py-pyyaml@3.13:", type=("build", "run"))
depends_on("spdlog")
depends_on("py-find-libpython", type=("run",))
Expand Down
4 changes: 3 additions & 1 deletion var/spack/repos/builtin/packages/py-sympy/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class PySympy(PythonPackage):

pypi = "sympy/sympy-0.7.6.tar.gz"

version("1.13.0", sha256="3b6af8f4d008b9a1a6a4268b335b984b23835f26d1d60b0526ebc71d48a25f57")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From upstream?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded the package from PyPI and did sha256sum sympy-1.13.0.tar.gz. The numbers for previous versions match this procedure, so I suppose that's the right thing to do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier: spack checksum <package>, and we should make sure that modifications to builtin packages make their way upstream. Otherwise, we're having a lot of fun with new deployments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I open a PR upstream as well then (for sympy, that is)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be very nice! Maybe check the dependencies for updates (they will otherwise)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted upstream at: spack#46163

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding the dependencies from there here too?

version("1.11.1", sha256="e32380dce63cb7c0108ed525570092fd45168bdae2faa17e528221ef72e88658")
version("1.8", sha256="1ca588a9f6ce6a323c5592f9635159c2093572826668a1022c75c75bdf0297cb")
version("1.7.1", sha256="a3de9261e97535b83bb8607b0da2c7d03126650fafea2b2789657b229c246b2e")
Expand All @@ -34,4 +35,5 @@ class PySympy(PythonPackage):

# pip silently replaces distutils with setuptools
depends_on("py-setuptools", type="build")
depends_on("py-mpmath@0.19:", when="@1.0:", type=("build", "run"))
depends_on("py-mpmath@0.19:", when="@1.0:1.12", type=("build", "run"))
depends_on("py-mpmath@1.1.0:1.3", when="@1.13.0:", type=("build", "run"))
Loading