-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nmodl, sympy: bump sympy version #2508
base: develop
Are you sure you want to change the base?
Conversation
Thank you for your pull request! Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running. |
@@ -11,6 +11,7 @@ class PySympy(PythonPackage): | |||
|
|||
pypi = "sympy/sympy-0.7.6.tar.gz" | |||
|
|||
version("1.13.0", sha256="3b6af8f4d008b9a1a6a4268b335b984b23835f26d1d60b0526ebc71d48a25f57") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downloaded the package from PyPI and did sha256sum sympy-1.13.0.tar.gz
. The numbers for previous versions match this procedure, so I suppose that's the right thing to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easier: spack checksum <package>
, and we should make sure that modifications to builtin
packages make their way upstream. Otherwise, we're having a lot of fun with new deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I open a PR upstream as well then (for sympy, that is)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be very nice! Maybe check the dependencies for updates (they will otherwise)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted upstream at: spack#46163
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding the dependencies from there here too?
The following build jobs of the deployment for this PR failed: |
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2508/config/modules.sh
module load unstable Please test the following updated modules:
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2508/config/modules.sh
module load unstable Please test the following updated modules:
|
No description provided.